Attention is currently required from: laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33693 )

Change subject: create pySim.legacy.ts_51_011.py and move legacy code there ......................................................................

Patch Set 3:

(2 comments)

File pySim/legacy/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/33693/comment/3dfae665_acd3b231 PS3, Line 3: # without this, pylint will fail when inner classes are used : # within the 'nested' kwarg of our TlvMeta metaclass on python 3.7 :( : # pylint This is not needed here anymore.

https://gerrit.osmocom.org/c/pysim/+/33693/comment/9914d887_3ffca067 PS3, Line 7: """ Various constants from 3GPP TS 51.011 used by *legacy* code only. I don't have a strong opinion here, but the fact that these definitions are used by legacy code only does not make them legacy themselves. Not sure if it's a good idea to move these to `legacy`. Why not keeping them in the original file? IMHO, the project's structure is getting even more complicated with `pySim.foo` and `pySim.legacy.foo`.