Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 ) Change subject: pySim/cards: Add type annotations ...................................................................... Patch Set 4: (4 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/33692/comment/e47574b2_734ddd41 PS4, Line 39: reset Missing return type annotation. Something like `-> Optional[...]` I guess? https://gerrit.osmocom.org/c/pysim/+/33692/comment/17002143_08d37582 PS4, Line 47: set_apdu_parameter Functions returning nothing should be annotated as such using `-> None`. https://gerrit.osmocom.org/c/pysim/+/33692/comment/73d3902d_9be8ec80 PS4, Line 124: Hexstr `-> Optional[Hexstr]` https://gerrit.osmocom.org/c/pysim/+/33692/comment/8dafc4b4_68299393 PS4, Line 134: Hexstr `-> Optional[Hexstr]` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id5752a64b59097584301c860ebf74d858ed3d240 Gerrit-Change-Number: 33692 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 12 Jul 2023 17:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment