Attention is currently required from: osmith.

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email )

Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ......................................................................

Patch Set 2:

(3 comments)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/573371e9_1a77126f?usp=... : PS2, Line 994: * - We shall send spares for radio (which happens to be the same as what's "spares"? "spare bits"? What do you mean with "radio" here?

https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/aa88333e_82a752a7?usp=... : PS2, Line 997: * - We could send a speech version list in theory that MS are then "We could in theory send a speech version list that"

https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/79cbe407_bfbf01d0?usp=... : PS2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. a define inside the enum).