Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... Patch Set 2: (3 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/573371e9_1a77126f?usp… : PS2, Line 994: * - We shall send spares for radio (which happens to be the same as what's "spares"? "spare bits"? What do you mean with "radio" here? https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/aa88333e_82a752a7?usp… : PS2, Line 997: * - We could send a speech version list in theory that MS are then "We could in theory send a speech version list that" https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/79cbe407_bfbf01d0?usp… : PS2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. a define inside the enum). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No