Attention is currently required from: osmith.

View Change

3 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #2, Line 994: * - We shall send spares for radio (which happens to be the same as

    what's "spares"? "spare bits"?
    What do you mean with "radio" here?

  • Patch Set #2, Line 997: * - We could send a speech version list in theory that MS are then

    "We could in theory send a speech version list that"

  • Patch Set #2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */

    If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. a define inside the enum).

To view, visit change 41043. To unsubscribe, or for help writing mail filters, visit settings.