Attention is currently required from: falconia, pespin, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/codec/codec.h:
https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/7f967f8a_c450e7e2
PS1, Line 85: etsi_sid_class
given that other functions just above/below use
osmo_{fr,efr,amr}, I would suggest to use that rathe […]
nevermind, it's just
the enum name that has osmo_gsm631 where that actually makes sense.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32183
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916
Gerrit-Change-Number: 32183
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 16 Apr 2023 09:07:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment