Attention is currently required from: falconia.

fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )

Change subject: FR/HR/EFR: centralize TCH UL SID classification ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/1f345a2a_434f314a?usp=... : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ : I suggest to return here, like you do above:

```suggestion return; ```

This way you can call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally, avoiding additional `lchan->tch_mode == ...` checks.

https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/5a168792_2f5f5b7e?usp=... : PS2, Line 2460: This logic can also set : * BFI that wasn't set before Is this really the case? I can see `tch_ul_msg_bfi()` being used to check for BFI, but not actually setting the BFI flag. Maybe this will be the case in one of the next patches?