Attention is currently required from: falconia.

Patch set 2:Code-Review +1

View Change

2 comments:

• File src/common/l1sap.c:

  • Patch Set #2, Line 2358:

    		/* This static function should never be called except for
    		 * V1 and EFR speech modes. */
    		
    

    I suggest to return here, like you do above:

    ```suggestion
    		return;
    ```

    This way you can call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally, avoiding additional `lchan->tch_mode == ...` checks.

  • Patch Set #2, Line 2460:

    This logic can also set
    	 * BFI that wasn't set before
    

    Is this really the case? I can see `tch_ul_msg_bfi()` being used to check for BFI, but not actually setting the BFI flag. Maybe this will be the case in one of the next patches?

To view, visit change 41048. To unsubscribe, or for help writing mail filters, visit settings.