Attention is currently required from: Hoernchen.

laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email )

Change subject: fix usb usb reset handling by delayed soft reset ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File sysmoOCTSIM/hpl/core/hpl_init.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445/comment/ce83f0f5_19c... : PS3, Line 63: // _oscctrl_init_referenced_generators(); here we have again those length commented-out blocks of code (even with single-line commenting). I don't get why we do this. Either we expect to need that code in the future in some situations - then there should be at least a human-readable comment explaining it, or ideally some #ifdef foo ... clause for the normal and non-standard situation. Or it's old cruft that is not needed and hence it can be removed; anyone interested can see in the commitlog.