Attention is currently required from: Hoernchen.

Patch set 3:Code-Review +1

View Change

1 comment:

• File sysmoOCTSIM/hpl/core/hpl_init.c:

  • Patch Set #3, Line 63: // _oscctrl_init_referenced_generators();

    here we have again those length commented-out blocks of code (even with single-line commenting). I don't get why we do this. Either we expect to need that code in the future in some situations - then there should be at least a human-readable comment explaining it, or ideally some #ifdef foo ... clause for the normal and non-standard situation. Or it's old cruft that is not needed and hence it can be removed; anyone interested can see in the commitlog.

To view, visit change 39445. To unsubscribe, or for help writing mail filters, visit settings.