Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )

Change subject: logging: change gsmtap target to use wqueue by default ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/184afbc5_ced71834?u... : PS1, Line 12: target, which can also be blocking under some circumstances. which can also be blocking if UDP socket buffer becomes full.

File include/osmocom/core/logging.h:

https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/ee83b3d6_0605adc1?u... : PS1, Line 356: bool ofd_wq_mode; this is breaking ABI.Can you check if log_target struct is used anywhere outside of libosmocore? If not, we can move this struct to an internal header.

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b6247ed3_1873a50e?u... : PS1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode) You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode:

if (!target->tgt_gsmtap.gsmtap_inst || target->tgt_gsmtap.gsmtap_inst->osmo_io_mode)