Attention is currently required from: fixeria.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 12: target, which can also be blocking under some circumstances.

    which can also be blocking if UDP socket buffer becomes full.

• File include/osmocom/core/logging.h:

  • Patch Set #1, Line 356: bool ofd_wq_mode;

    this is breaking ABI.Can you check if log_target struct is used anywhere outside of libosmocore? If not, we can move this struct to an internal header.

• File src/vty/logging_vty.c:

  • Patch Set #1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode)

    You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode:

        if (!target->tgt_gsmtap.gsmtap_inst || target->tgt_gsmtap.gsmtap_inst->osmo_io_mode)

To view, visit change 41685. To unsubscribe, or for help writing mail filters, visit settings.