Attention is currently required from: laforge, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ......................................................................
Patch Set 57:
(4 comments)
File src/libsmpputil/smpp_msc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/a1a8b9d7_5537ec00 PS57, Line 849: The bad side of using auto-formatting :)
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/0fd4aa27_7eeae12a PS49, Line 347: osmo_stream_srv_send(esme->srv, msg);
Yes?
osmo_stream_srv_send() returns no value...
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/012cac07_f5a7e68a PS57, Line 767: return -ENOMEM; I know it's unlikely that msgb_alloc() would return NULL, but still: shouldn't we close the connection here? libosmonetif has some data for you, so it calls your callback, but you don't read() from socket. Data is still there, so I guess it will keep calling your callback again and again?
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/1e47a141_65cde513 PS57, Line 855: lost I would say 'closed', because 'lost' sounds like things went wrong.
-
fixeria