Attention is currently required from: laforge, pespin, msuraev.

View Change

4 comments:

• File src/libsmpputil/smpp_msc.c:

  • Patch Set #57, Line 849:

    The bad side of using auto-formatting :)

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #49, Line 347: osmo_stream_srv_send(esme->srv, msg);

    Yes?

    osmo_stream_srv_send() returns no value...

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #57, Line 767: return -ENOMEM;

    I know it's unlikely that msgb_alloc() would return NULL, but still: shouldn't we close the connection here? libosmonetif has some data for you, so it calls your callback, but you don't read() from socket. Data is still there, so I guess it will keep calling your callback again and again?

  • Patch Set #57, Line 855: lost

    I would say 'closed', because 'lost' sounds like things went wrong.

To view, visit change 28849. To unsubscribe, or for help writing mail filters, visit settings.