Attention is currently required from: neels, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 4: Code-Review-1 (6 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/344bdb1d_c166f141 PS4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s", This line needs updating. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/225ce6fd_513954e4 PS4, Line 86: { 0, NULL }, unaligned https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cf3c4202_ae4bba1b PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); maybe add a comment here that you are initializing the list so that it can be llist_deleted() later on even if it has not been added to any list. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7566fa90_04245a66 PS1, Line 92: struct gsm_bts *bts, Actually, I see now that you are changing the formatting of this line for now reason, so leave it was it was. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/087a9eef_ba389864 PS4, Line 401: .ignore_invalid_events = As mentioned I don't think this is needed. We can discuss it further. File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2d9d782d_37e97cfd PS4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr) This is wrong. You are not adding the param "bool allow_opstart" to this function which should allow the opstart to be sent only under OFFLINE state, not in DEPENDENCY. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Oct 2022 10:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment