Attention is currently required from: neels, fixeria, lynxis lazus.

Patch set 4:Code-Review -1

View Change

6 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s",

    This line needs updating.

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #4, Line 86: { 0, NULL },

    unaligned

  • Patch Set #4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list);

    maybe add a comment here that you are initializing the list so that it can be llist_deleted() later on even if it has not been added to any list.

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #1, Line 92: struct gsm_bts *bts,

    You could check all the other configure_loop() functions and use the same format as in all of them ; […]

    Actually, I see now that you are changing the formatting of this line for now reason, so leave it was it was.

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #4, Line 401: .ignore_invalid_events =

    As mentioned I don't think this is needed. We can discuss it further.

• File src/osmo-bsc/nm_bts_sm_fsm.c:

  • Patch Set #4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr)

    This is wrong. You are not adding the param "bool allow_opstart" to this function which should allow the opstart to be sent only under OFFLINE state, not in DEPENDENCY.

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.