osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Fix various uninitialized value errors Fixes: CID#272949, CID#272951, CID#272974, CID#274685 Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f --- M src/coding/gsm0503_coding.c M src/gsm/gsm23236.c M tests/codec/codec_ecu_fr_test.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/33400/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 80286f7..97f5c97 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2194,7 +2194,7 @@ uint8_t *cmr, int *n_errors, int *n_bits_total, uint8_t *dtx) { sbit_t iB[912], cB[456], h; - ubit_t d[244], p[6], conv[250]; + ubit_t d[244], p[6], conv[250] = {}; int i, rv, len, steal = 0, id = -1; *n_errors = 0; *n_bits_total = 0; static ubit_t sid_first_dummy[64] = { 0 }; diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index 4a83ec8..a80ecf4 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -487,7 +487,7 @@ int osmo_nri_ranges_vty_add(const char **message, struct osmo_nri_range *added_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv, uint8_t nri_bitlen) { - struct osmo_nri_range add_range; + struct osmo_nri_range add_range = {}; if (osmo_nri_parse_range(&add_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; @@ -523,7 +523,7 @@ int osmo_nri_ranges_vty_del(const char **message, struct osmo_nri_range *removed_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv) { - struct osmo_nri_range del_range; + struct osmo_nri_range del_range = {}; if (osmo_nri_parse_range(&del_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; diff --git a/tests/codec/codec_ecu_fr_test.c b/tests/codec/codec_ecu_fr_test.c index 4e5b71d..fe64685 100644 --- a/tests/codec/codec_ecu_fr_test.c +++ b/tests/codec/codec_ecu_fr_test.c @@ -107,7 +107,7 @@ */ void test_fr_concealment(void) { - struct osmo_ecu_fr_state state; + struct osmo_ecu_fr_state state = {}; uint8_t frame[GSM_FR_BYTES]; uint64_t xmaxc[4]; int i, rc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange