Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42176?usp=email )

Change subject: dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section ......................................................................

Patch Set 4: Code-Review+1

(1 comment)

Patchset:

PS2:

The ISR only reads these variables when dfu_state == DFU_MANIFEST_SYNC, the main loop only writes th […]

Thanks for providing context. Do we agree it's still good practice to put it in a critical section? To prevent someone in the future shooting themselves into the foot? It's not like the very brief disabling of interrupts (critical section) for the duration of one load and two stores is going to introduce additional risks in something that doens't strike me as hyper-critical code path?