Attention is currently required from: lynxis lazus.

Patch set 4:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    The ISR only reads these variables when dfu_state == DFU_MANIFEST_SYNC, the main loop only writes th […]

    Thanks for providing context. Do we agree it's still good practice to put it in a critical section? To prevent someone in the future shooting themselves into the foot? It's not like the very brief disabling of interrupts (critical section) for the duration of one load and two stores is going to introduce additional risks in something that doens't strike me as hyper-critical code path?

To view, visit change 42176. To unsubscribe, or for help writing mail filters, visit settings.