Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 )
Change subject: osmo_io: Avoid potential double free when sending msgb ......................................................................
Patch Set 2:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/63fdfb67_ddb992e6 PS2, Line 106: talloc_steal(iofd, msg);
Here iofd_msghdr_alloc is called with a msg - this happens in the send path when a user calls osmo_i […]
what about actually parenting msg to the msghdr here? it's what probably makes more sense? Since during the Tx path you probably want to free them both at the same time, and in the Rx path you want to talloc_steal the msg to the user ctx and free hdr.