Attention is currently required from: daniel.
View Change
1 comment:
File src/core/osmo_io.c:
Patch Set #2, Line 106: talloc_steal(iofd, msg);
Here iofd_msghdr_alloc is called with a msg - this happens in the send path when a user calls osmo_i […]
what about actually parenting msg to the msghdr here? it's what probably makes more sense? Since during the Tx path you probably want to free them both at the same time, and in the Rx path you want to talloc_steal the msg to the user ctx and free hdr.
To view, visit change 34144. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94
Gerrit-Change-Number: 34144
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Aug 2023 15:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment