Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536 )

Change subject: Workaround bug where old hnb_context from same remote addr+port is kept ......................................................................

Patch Set 2:

(3 comments)

File src/osmo-hnbgw/hnbgw_hnbap.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/dbed6eb0_e9d57d1e PS2, Line 426: if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) { (early-exit coding style would be nicer like

if (!(...)) continue; ...

then the new code block would need less indenting)

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/6184dee5_2e036efb PS2, Line 428: bug is it really a bug?? from the commit log it sounds like it is handling a hnb peer that opens a second conn for the same context?

if it's a bug it should be possible to figure out how such bug is possible?

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/738ca6fc_1f96b35e PS2, Line 434: LOGHNB(ctx, DHNBAP, LOGL_ERROR, "BUG! Found old registered HNB with invalid socket, releasing it\n"); IMHO the error logs could more clearly indicate that the same HNB is registering a second time, that we have an old record of the *same* HNB that is requesting to register now.