Attention is currently required from: pespin.
3 comments:
File src/osmo-hnbgw/hnbgw_hnbap.c:
Patch Set #2, Line 426: if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) {
(early-exit coding style would be nicer like
if (!(...))
continue;
...
then the new code block would need less indenting)
is it really a bug??
from the commit log it sounds like it is handling a hnb peer that opens a second conn for the same context?
if it's a bug it should be possible to figure out how such bug is possible?
Patch Set #2, Line 434: LOGHNB(ctx, DHNBAP, LOGL_ERROR, "BUG! Found old registered HNB with invalid socket, releasing it\n");
IMHO the error logs could more clearly indicate that the same HNB is registering a second time, that we have an old record of the *same* HNB that is requesting to register now.
To view, visit change 29536. To unsubscribe, or for help writing mail filters, visit settings.