Attention is currently required from: laforge, neels.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email )
Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/331acdbc_495d31c8?u… :
PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went
: down" should already be handled by libosmo-sigtran's sccp SAP
: internally, and we should simply recieve an N-DISCONNECT.ind when that
: happens which dispatches event MAP_SCCP_EV_RX_RELEASED.
There seems to be a mixup of events when receiving an
SCCP N-PCSTATE. […]
This looks like a bug introduced in osmo-hnbgw.git
b1c0bb19e2bfbc48e05a89a5f09b476d1243b5f3, the commit where MAP_SCCP_EV_CN_LINK_LOST was
introduced but never dispatched anywhere. Looks like there was probably a copy-paste issue
in there. I'll continue investigating and submit a new patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2
Gerrit-Change-Number: 40175
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 30 Apr 2025 12:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>