Attention is currently required from: laforge, pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support ......................................................................
Patch Set 13:
(9 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c93ce73_fc68b288 PS10, Line 15: C
can you please document that setup on a wiki page on osmocom. […]
Done
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92ab80ee_46e9c7e5 PS3, Line 115: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure. […]
Done
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/952e7977_153895b0 PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
$(top_srcdir)/Transceiver52/device/ipc? not sure if it's a good idea to use relative paths there.
abosolutely does not matter here, the directory layout has been unchanged for 10 years and this directory is still called transceiver52m even though that refers to usrp1 days and issues, no reason to expect dynamically changing dir layouts, ever.
File Transceiver52M/ms/itrq.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a67390c4_89e8ee9d PS11, Line 127: class spsc : public T<block_read, block_write> {
didn't we have an implementation of this somewhere else already?
a clumsy bad c copy of this, yes.
File Transceiver52M/ms/logging.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b3b7da2_8fe9b53d PS11, Line 83: void trxc_log_init(void *tallctx)
shouldn't this be called "trxcon_log_init"?
Done
File Transceiver52M/ms/ms.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5b6bc2f_3c64343f PS11, Line 312: // in thory fn equal and tn+3 equal is also a problem...
theory
Done
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66a6017f_27acb1b9 PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
value_string?
Done
File Transceiver52M/ms/sch.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c086632_77c67f34 PS11, Line 7: * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH info@sysmocom.de / Eric Wild ewild@sysmocom.de
repeated "2022 by"
Done
File Transceiver52M/ms/sch.c:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b49d8864_26d0b63c PS11, Line 97: int gsm_fcch_check_fn(int fn)
don't we have these sort of functionalities already in libosmocore?
the whole file is copy&paste of various private libosmocore parts, originally created by tom tsou in his ms branch 10 years ago, which is also where this transceiver started, and then I kept adding to it.
That being said I had a look at libosmocore, but stuff I need is either internal, or does not exist, i.e. sch reduced fn to gsm time and so on.
-
Hoernchen