Attention is currently required from: laforge, pespin, fixeria.
9 comments:
Commit Message:
can you please document that setup on a wiki page on osmocom. […]
Done
File Transceiver52M/Makefile.am:
Patch Set #3, Line 115: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure. […]
Done
File Transceiver52M/Makefile.am:
Patch Set #11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
$(top_srcdir)/Transceiver52/device/ipc? not sure if it's a good idea to use relative paths there.
abosolutely does not matter here, the directory layout has been unchanged for 10 years and this directory is still called transceiver52m even though that refers to usrp1 days and issues, no reason to expect dynamically changing dir layouts, ever.
File Transceiver52M/ms/itrq.h:
Patch Set #11, Line 127: class spsc : public T<block_read, block_write> {
didn't we have an implementation of this somewhere else already?
a clumsy bad c copy of this, yes.
File Transceiver52M/ms/logging.cpp:
Patch Set #11, Line 83: void trxc_log_init(void *tallctx)
shouldn't this be called "trxcon_log_init"?
Done
File Transceiver52M/ms/ms.cpp:
Patch Set #11, Line 312: // in thory fn equal and tn+3 equal is also a problem...
theory
Done
File Transceiver52M/ms/ms_upper.cpp:
Patch Set #11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
value_string?
Done
File Transceiver52M/ms/sch.h:
Patch Set #11, Line 7: * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH <info@sysmocom.de> / Eric Wild <ewild@sysmocom.de>
repeated "2022 by"
Done
File Transceiver52M/ms/sch.c:
Patch Set #11, Line 97: int gsm_fcch_check_fn(int fn)
don't we have these sort of functionalities already in libosmocore?
the whole file is copy&paste of various private libosmocore parts, originally created by tom tsou in his ms branch 10 years ago, which is also where this transceiver started, and then I kept adding to it.
That being said I had a look at libosmocore, but stuff I need is either internal, or does not exist, i.e. sch reduced fn to gsm time and so on.
To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.