Attention is currently required from: fixeria, pespin, daniel.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )

Change subject: gsm/ipa: Add segmentation callback ......................................................................

Patch Set 6:

(2 comments)

File src/gsm/ipa.c:

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/f4ea7d54_1fcfe8c4 PS2, Line 730: msg->data_len < total_len

This (is supposed to) check the case where the msgb is not large enough to contain a complete messag […]

Seems better to me, as that would prevent more error cases

File src/gsm/ipa.c:

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/5774f60e_8acd6911 PS5, Line 722: int ipa_segmentation_cb(struct msgb *msg)

This definetly requires documentation on params, return code, behavior, etc.

Semantics are explained in change I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377, I could add