Attention is currently required from: fixeria, pespin, daniel.

View Change

2 comments:

• File src/gsm/ipa.c:

  • Patch Set #2, Line 730: msg->data_len < total_len

    This (is supposed to) check the case where the msgb is not large enough to contain a complete messag […]

    Seems better to me, as that would prevent more error cases

• File src/gsm/ipa.c:

  • Patch Set #5, Line 722: int ipa_segmentation_cb(struct msgb *msg)

    This definetly requires documentation on params, return code, behavior, etc.

    Semantics are explained in change I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377, I could add

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.