Attention is currently required from: pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )

Change subject: Make esme struct shared ......................................................................

Patch Set 19: Code-Review-1

(4 comments)

File include/osmocom/smpp/smpp.h:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/75e5796c_038ce042 PS19, Line 14: struct esme { prefer 'struct smpp_esme' since it is from smpp.h

File include/osmocom/smpp/smpp_smsc.h:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/eb66d78b_c63ea6c8 PS19, Line 32: struct esme *esme; just 'struct esme esme;' (non-pointer) to avoid extra talloc, then smpp_esme_init(&osmo_esme.esme) instead of esme_alloc()

File src/libsmpputil/smpp_smsc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dcef0350_bd4e35a1 PS19, Line 900: esme->esme = esme_alloc(esme); ...because the esme_alloc() appears to unconditionally take place after talloc(struct osmo_esme) anyway.

File src/utils/Makefile.am:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f65950f5_9b47607a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \ smpp_mirror certainly does not need libvlr.a. also looks weird to require libmsc.a. and pull in ASN1C, SIGTRAN and SQLITE3 below...

can you find a way to not pull in all sorts of unrelated dependencies? just guessing, maybe move the esme implementation from libmsc to libsmpputil?