Attention is currently required from: pespin, msuraev, dexter.

Patch set 19:Code-Review -1

View Change

4 comments:

• File include/osmocom/smpp/smpp.h:

  • Patch Set #19, Line 14: struct esme {

    prefer 'struct smpp_esme' since it is from smpp.h

• File include/osmocom/smpp/smpp_smsc.h:

  • Patch Set #19, Line 32: struct esme *esme;

    just 'struct esme esme;' (non-pointer) to avoid extra talloc,
    then smpp_esme_init(&osmo_esme.esme) instead of esme_alloc()

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #19, Line 900: esme->esme = esme_alloc(esme);

    ...because the esme_alloc() appears to unconditionally take place after talloc(struct osmo_esme) anyway.

• File src/utils/Makefile.am:

  • Patch Set #19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \

    smpp_mirror certainly does not need libvlr.a.
    also looks weird to require libmsc.a.
    and pull in ASN1C, SIGTRAN and SQLITE3 below...

    can you find a way to not pull in all sorts of unrelated dependencies?
    just guessing, maybe move the esme implementation from libmsc to libsmpputil?

To view, visit change 28846. To unsubscribe, or for help writing mail filters, visit settings.