Attention is currently required from: neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )

Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................

Patch Set 3:

(2 comments)

File include/osmocom/gprs/llc/llc.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/b19029b2_a7bd18f6 PS3, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?

File tests/llc_pdu_codec/pdu_codec_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/fb066c00_a515678c PS3, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const