Attention is currently required from: neels, pespin.

View Change

2 comments:

• File include/osmocom/gprs/llc/llc.h:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58):

    Patch Set #3, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */

    'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?

• File tests/llc_pdu_codec/pdu_codec_test.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58):

    Patch Set #3, Line 31: static const char *testData[] = {

    static const char * array should probably be static const char * const

To view, visit change 29402. To unsubscribe, or for help writing mail filters, visit settings.