Attention is currently required from: laforge, neels, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )

Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ......................................................................

Patch Set 15:

(6 comments)

This change is ready for review.

File src/iu_client.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/71694afe_973202a2?usp=... : PS13, Line 900: %d RN

(then again this looks like multiple matches are possible) […]

Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/5f486587_01b5bca3?usp=... : PS13, Line 909: LOGPIUC(log_level, ", for IMSI %s\n", imsi);

please avoid LOGPC, because for gsm_tap_log it rips apart log lines to multiple gsmtap packages. […]

Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3ee6ee43_9380816b?usp=... : PS13, Line 938: }

if (paged) break?

break is fine. See above.

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0637b079_767a53b3?usp=... : PS13, Line 943: LOGL_INFO

this previously was LOGL_ERROR and the _cs2 also does ERROR. […]

Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/58277522_59653763?usp=... : PS13, Line 945: sprintf(log_msg, "Paged %d RNCs", paged);

snprintf()

Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/f4ac9b70_5b47bfa5?usp=... : PS13, Line 954: LOGPIUC(log_level, ", for IMSI %s\n", imsi);

avoid LOGPC

Done