[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 - gerrit-log

20 Feb 2025

Attention is currently required from: laforge, neels, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )

Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2
......................................................................

Patch Set 15:

(6 comments)

This change is ready for review.

File src/iu_client.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/71694afe_973202a2?usp… :
PS13, Line 900:  %d RN
...
  (then again this looks like multiple matches are
possible) […] Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/5f486587_01b5bca3?usp… :
PS13, Line 909: 		LOGPIUC(log_level, ", for IMSI %s\n", imsi);
...
  please avoid LOGPC, because for gsm_tap_log it rips
apart log lines to multiple gsmtap packages. […] Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3ee6ee43_9380816b?usp… :
PS13, Line 938: 		}
...
  if (paged) break? break is fine. See above.

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0637b079_767a53b3?usp… :
PS13, Line 943: LOGL_INFO
...
  this previously was LOGL_ERROR and the _cs2 also does
ERROR. […] Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/58277522_59653763?usp… :
PS13, Line 945: 		sprintf(log_msg, "Paged %d RNCs", paged);
...
  snprintf() Done

https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/f4ac9b70_5b47bfa5?usp… :
PS13, Line 954: 		LOGPIUC(log_level, ", for IMSI %s\n", imsi);
...
  avoid LOGPC Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd
Gerrit-Change-Number: 38946
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 20 Feb 2025 15:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;