Attention is currently required from: laforge, neels, pespin.

View Change

6 comments:

• File src/iu_client.c:

  • Patch Set #13, Line 900: %d RN

    (then again this looks like multiple matches are possible) […]

    Done

  • Patch Set #13, Line 909: LOGPIUC(log_level, ", for IMSI %s\n", imsi);

    please avoid LOGPC, because for gsm_tap_log it rips apart log lines to multiple gsmtap packages. […]

    Done

  • Patch Set #13, Line 938: }

    if (paged) break?

    break is fine. See above.

  • Patch Set #13, Line 943: LOGL_INFO

    this previously was LOGL_ERROR and the _cs2 also does ERROR. […]

    Done

  • Patch Set #13, Line 945: sprintf(log_msg, "Paged %d RNCs", paged);

    snprintf()

    Done

  • Patch Set #13, Line 954: LOGPIUC(log_level, ", for IMSI %s\n", imsi);

    avoid LOGPC

    Done

To view, visit change 38946. To unsubscribe, or for help writing mail filters, visit settings.