Attention is currently required from: jolly, pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email )

Change subject: stream_cli: Correctly setup and free osmo_io client instance ......................................................................

Patch Set 7: Code-Review-1

(1 comment)

Patchset:

PS7: Can you explain why you need to free the iofd? There seems to (now) be a memory leak in osmo_stream_cli_open().

The old code I'm looking at locally has this in the open function to guard against:

```c if (!cli->iofd) cli->iofd = osmo_iofd_setup(cli, fd, cli->name, OSMO_IO_FD_MODE_READ_WRITE, &osmo_stream_cli_ioops, cli); if (!cli->iofd) goto error_close_socket; ```

It seems it was removed in commit 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61