Attention is currently required from: jolly, pespin.

Patch set 7:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #7:

    Can you explain why you need to free the iofd? There seems to (now) be a memory leak in osmo_stream_cli_open().

    The old code I'm looking at locally has this in the open function to guard against:

    ```c
    		if (!cli->iofd)
    			cli->iofd = osmo_iofd_setup(cli, fd, cli->name, OSMO_IO_FD_MODE_READ_WRITE, &osmo_stream_cli_ioops, cli);
    		if (!cli->iofd)
    			goto error_close_socket;
    ```

    
    It seems it was removed in commit 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61

To view, visit change 35979. To unsubscribe, or for help writing mail filters, visit settings.