Attention is currently required from: dexter, laforge, neels, pespin.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ......................................................................
Patch Set 16:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39742/comment/700e9523_cd141005?usp=ema... : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the
re the build failure, dear Vadim, on the contrary. This is a prime example why we don't need to prevent instantiation. The apply_val() implementation follows in a separate patch, neatly separated for readability during CR. I spent time to separate that.
If something is not there yet, one can still define a stub like this:
``` def apply_val(cls, pes: ProfileElementSequence, val): raise NotImplementedError # XXX/TODO
```
Anyways, I am not willing/going to block here. "Heightening the misery" is certainly not what I was aiming for. I just shared my understanding of the `abc` stuff in Python and I am sorry if my comments were giving you additional headaches. This is not a project that I am directly involved in and you're not modifying the code that I wrote, so I am bailing out from the review loop of this patchset.