Attention is currently required from: dexter, laforge, neels, pespin.

View Change

1 comment:

• File pySim/esim/saip/personalization.py:

  • Patch Set #13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the

    re the build failure, dear Vadim, on the contrary.
    This is a prime example why we don't need to prevent instantiation.
    The apply_val() implementation follows in a separate patch, neatly separated for readability during CR. I spent time to separate that.

    If something is not there yet, one can still define a stub like this:

    ```
    def apply_val(cls, pes: ProfileElementSequence, val):
        raise NotImplementedError # XXX/TODO

    ```

    Anyways, I am not willing/going to block here. "Heightening the misery" is certainly not what I was aiming for. I just shared my understanding of the `abc` stuff in Python and I am sorry if my comments were giving you additional headaches. This is not a project that I am directly involved in and you're not modifying the code that I wrote, so I am bailing out from the review loop of this patchset.

To view, visit change 39742. To unsubscribe, or for help writing mail filters, visit settings.