Attention is currently required from: fixeria, pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email )

Change subject: vty: make NCC Permitted (SI2) configurable ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/177916e8_98a21a27 PS1, Line 1447: no ncc-permitted

ACK, I also found it a bit confusing and I was expecting some "all" value.

I see how "no ncc-permitted" meaning all is confusing. I'll add "ncc-permitted all" instead.

Regarding "no ncc-permitted 2" syntax: I think this will also be confusing when used in combination with ncc-permitted without "no" or when used multiple times, e.g.:

``` ncc-permitted 2 3 4 5 no ncc-permitted 2 no ncc-permitted 3 ```

It's not clear for users reading the config what will happen here, it could be implemented as resulting in "ncc-permitted 1 2 4 5 6 7 8" or resulting in "ncc-permitted 4 5". Therefore I think it's best to not add "no ncc-permitted" for disabling specific NCC values.