Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email ) Change subject: vty: make NCC Permitted (SI2) configurable ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/177916e8_98a21a27 PS1, Line 1447: no ncc-permitted
ACK, I also found it a bit confusing and I was expecting some "all" value. I see how "no ncc-permitted" meaning all is confusing. I'll add "ncc-permitted all" instead.
Regarding "no ncc-permitted 2" syntax: I think this will also be confusing when used in combination with ncc-permitted without "no" or when used multiple times, e.g.: ``` ncc-permitted 2 3 4 5 no ncc-permitted 2 no ncc-permitted 3 ``` It's not clear for users reading the config what will happen here, it could be implemented as resulting in "ncc-permitted 1 2 4 5 6 7 8" or resulting in "ncc-permitted 4 5". Therefore I think it's best to not add "no ncc-permitted" for disabling specific NCC values. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71bb855c35378f8f0598bc11a42bd274b7232a5e Gerrit-Change-Number: 34543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Sep 2023 10:10:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment