Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )
Change subject: cbc: Test ETWS msg over CBSP ......................................................................
Patch Set 3:
(2 comments)
File cbc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/089eaaa0_9c1cf... PS3, Line 101: var template (omit) uint8_t channel_ind := omit;
I think I got problems there about the field being uninitialized, because as part of a record it's n […]
If it can be uninitialized, then I think you should be using isbound(). Otherwise it's confusing.
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/dfdbcac7_6ab73... PS3, Line 353: g_pars.exp_cbs_msg.channel_ind
no, because msg.channel_ind field is optional, since ETWS messages don't contain a channel_ind.
Same here, better use isbound().
-
fixeria