Attention is currently required from: osmith, pespin.

View Change

2 comments:

• File cbc/BSC_ConnectionHandler.ttcn:

  • Patch Set #3, Line 101: var template (omit) uint8_t channel_ind := omit;

    I think I got problems there about the field being uninitialized, because as part of a record it's n […]

    If it can be uninitialized, then I think you should be using isbound(). Otherwise it's confusing.

• File cbc/CBC_Tests.ttcn:

  • Patch Set #3, Line 353: g_pars.exp_cbs_msg.channel_ind

    no, because msg.channel_ind field is optional, since ETWS messages don't contain a channel_ind.

    Same here, better use isbound().

To view, visit change 28912. To unsubscribe, or for help writing mail filters, visit settings.