Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email )
Change subject: ASCI: Add channel notification event to MM events ......................................................................
Patch Set 5:
(2 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/b386c011_6699f34d PS5, Line 170: uint8_t sres[4];
the sres is used with all events? or with some specific event only?
Looks like we want a `union` here.
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/0ccb5013_f1ff9408 PS5, Line 176: notification btw, this struct is not going to be packed even though it's defined in a packed struct. Not sure if this is really important, since it's not actually being sent over the wire, but JFYI.