Attention is currently required from: jolly, pespin.

View Change

2 comments:

• File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:

  • Patch Set #5, Line 170: uint8_t sres[4];

    the sres is used with all events? or with some specific event only?

    Looks like we want a `union` here.

  • Patch Set #5, Line 176: notification

    btw, this struct is not going to be packed even though it's defined in a packed struct. Not sure if this is really important, since it's not actually being sent over the wire, but JFYI.

To view, visit change 34488. To unsubscribe, or for help writing mail filters, visit settings.