Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 )
Change subject: mobile: integrate GAPK based audio (voice) I/O support ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
My magic glass ball that I use to predict where things are going tells me that 1) this will be audib […]
The question is what "suffices" vs the effort. Having queues that can grow indefinite is always bad. Having a simple limit fo the number of frames is adding very few lines of code. Yes, it will suck, but I'd rather have a very audible gap in speech than ever-growing delay in the call.
Yes, you can always improve, if you want. But at a higher effort. The probably 6 lines more code for queue size limits are so easy to add, that it should be a no-brainer.
-
laforge