Attention is currently required from: Hoernchen, fixeria.
View Change
1 comment:
Patchset:
Patch Set #5:
My magic glass ball that I use to predict where things are going tells me that 1) this will be audib […]
The question is what "suffices" vs the effort. Having queues that can grow indefinite is always bad. Having a simple limit fo the number of frames is adding very few lines of code. Yes, it will suck, but I'd rather have a very audible gap in speech than ever-growing delay in the call.
Yes, you can always improve, if you want. But at a higher effort. The probably 6 lines more code for queue size limits are so easy to add, that it should be a no-brainer.
To view, visit change 30337. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9
Gerrit-Change-Number: 30337
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <axilirator@gmail.com>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Nov 2022 19:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment