Attention is currently required from: neels.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email )

Change subject: sip: tweak failure reporting for SIP messages ......................................................................

Patch Set 1:

(1 comment)

File sip/SIP_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415/comment/5762c8e1_886e4... PS1, Line 195: og("FAIL: expected SIP message ", sip_expect); : setverdict(fail, "Received unexpected SIP message"); I don't really like this kind of duplication. The first log line contains the sip_expect, but the setverdict doesn't. However, you can just as well log any variable of any type in setverdict, too. So simply do a setverdict(fail, "Received unexpected SIP message ", sip_expect) instead?

Also, the succession of setverdict + stopping a component sounds like you may want to consider using a Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, ...) construct?