Attention is currently required from: neels.

View Change

1 comment:

• File sip/SIP_Tests.ttcn:

  • Patch Set #1, Line 195:

    og("FAIL: expected SIP message ", sip_expect);
    		setverdict(fail, "Received unexpected SIP message");
    

    I don't really like this kind of duplication. The first log line contains the sip_expect, but the setverdict doesn't. However, you can just as well log any variable of any type in setverdict, too. So simply do a setverdict(fail, "Received unexpected SIP message ", sip_expect) instead?

    Also, the succession of setverdict + stopping a component sounds like you may want to consider using a Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, ...) construct?

To view, visit change 34415. To unsubscribe, or for help writing mail filters, visit settings.