Attention is currently required from: Timur Davydov, laforge, neels.

pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )

Change subject: Add Emscripten build support and JS callback logging backend ......................................................................

Patch Set 8:

(2 comments)

File src/core/logging_emscripten.c:

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/7358986e_c7fa421d?u... : PS7, Line 24: /*! \addtogroup logging

Thanks for the suggestion, agreed. […]

Please make sure you rebase your work on top of current master, I did some changes to configure.ac and they got merged today in master and you'll probably need to adapt your new patch version.

File src/core/netdev.c:

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/c3ce9e9b_c68d33bc?u... : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

To clarify: the first problem is actually a conditional compilation within the source code itself. […]

Great, please submit a separate patch with those changes (since they are actually independent from emscripten).