Attention is currently required from: Timur Davydov, laforge, neels.

View Change

2 comments:

• File src/core/logging_emscripten.c:

  • Patch Set #7, Line 24: /*! \addtogroup logging

    Thanks for the suggestion, agreed. […]

    Please make sure you rebase your work on top of current master, I did some changes to configure.ac and they got merged today in master and you'll probably need to adapt your new patch version.

• File src/core/netdev.c:

  • Patch Set #5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

    To clarify: the first problem is actually a conditional compilation within the source code itself. […]

    Great, please submit a separate patch with those changes (since they are actually independent from emscripten).

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.