Attention is currently required from: arehbein, daniel, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34526?usp=email )
Change subject: meas_feed: Use osmo_io instead of write queue ......................................................................
Patch Set 6:
(2 comments)
File src/osmo-bsc/meas_feed.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/90a2121e_c07296f8 PS6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT};
I kind of like using a different style for structs as opposed to the style used for function definit […]
I gree with Daniel, we usually use the way he proposed. For sure at least you should leave some space before/after "{ }"
https://gerrit.osmocom.org/c/osmo-bsc/+/34526/comment/5b57b162_4bfcb0ba PS6, Line 133: struct osmo_io_ops meas_feed_oio = {.read_cb = NULL, .write_cb = meas_feed_noop_cb,
Here as well
Ack
-
pespin